Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do specify our copyright in LICENSE file, unify name with dandiarchive.org, make year auto update in docs #1574

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Do specify our copyright in LICENSE file, unify name with dandiarchive.org, make year auto update in docs #1574

merged 3 commits into from
Feb 13, 2025
+24 −3

Conversation

yarikoptic
Copy link
Member

@yarikoptic
Do specify our copyright line (with years range) in LICENSE file
a4ba636 
Apparently we had a template and never bothered to adjust it
@yarikoptic
Add workflow which should trigger update of copyright year
114d2f0 
Ideally we should restrict it to only "useful" changes, e.g. under
dandi/ folder. Filed

- FantasticFiasco/action-update-license-year#626
@yarikoptic
Make year in sphinx auto-update on build, unify name to how on dandia…
39221c1 
…rchive.org
@yarikoptic yarikoptic added the internal Changes only affect the internal API label Feb 11, 2025
@yarikoptic yarikoptic requested a review from jwodder February 11, 2025 23:32
@codecov Codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (1bd44f0) to head (39221c1).
Report is 39 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1574      +/-   ##
==========================================
+ Coverage   88.31%   88.40%   +0.08%     
==========================================
  Files          78       78              
  Lines       10735    10735              
==========================================
+ Hits         9481     9490       +9     
+ Misses       1254     1245       -9
Flag Coverage Δ
unittests 88.40% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jwodder
jwodder reviewed Feb 12, 2025
View reviewed changes
LICENSE
@@ -186,7 +186,7 @@
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]
Copyright 2019-2024 The DANDI Team
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not through 2025? Are you testing the workflow out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to mention -- I intentionally left it this way to see what action which I am introducing here would do.

@yarikoptic
Copy link
Member Author

tests fail was unrelated

FAILED dandi/tests/test_organize.py::test_organize_nwb_test_data[-1-dry] - pytest.PytestUnhandledThreadExceptionWarning: Exception in thread ExecutorManagerThread

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/threading.py", line 980, in _bootstrap_inner
    self.run()
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/site-packages/joblib/externals/loky/process_executor.py", line 602, in run
    self.process_result_item(result_item)
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/site-packages/joblib/externals/loky/process_executor.py", line 752, in process_result_item
    warnings.warn(
UserWarning: A worker stopped while some jobs were given to the executor. This can be caused by a too short worker timeout or by a memory leak.

@yarikoptic
Copy link
Member Author

ok, tested on my personal fork

@yarikoptic yarikoptic merged commit c8ed7dd into master Feb 13, 2025
25 of 26 checks passed
@yarikoptic yarikoptic deleted the enh-auto-year branch February 13, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwodder jwodder jwodder left review comments

Assignees
No one assigned
Labels
internal Changes only affect the internal API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yarikoptic @jwodder